Messages in this thread | | | Date | Fri, 21 Apr 2017 19:58:37 -0700 | From | Stephen Boyd <> | Subject | Re: [RFC PATCH 2/3] clk: add managed version of clk_bulk_get |
| |
On 04/13, Dong Aisheng wrote: > On Wed, Apr 12, 2017 at 12:03:28PM +0800, Dong Aisheng wrote: > > drivers/built-in.o: In function `devm_clk_bulk_get': > >> (.text+0x1930e): undefined reference to `clk_bulk_get' > drivers/built-in.o: In function `devm_clk_bulk_release': > >> clk-devres.c:(.text+0x19370): undefined reference to `clk_bulk_put' > > clk_bulk_get is defined in clkdev.c which depends on CONFIG_CLKDEV_LOOKUP. > However, some platforms like m68k may not select CLKDEV_LOOKUP but > select HAVE_CLK. Thus compiling devm_clk_bulk_get may cause a undefined > reference to 'clk_bulk_get'. > > Since clk_bulk_get is built upon the platform specific clk_get api, > clk_bulk_get can also be used by that platform accordingly. > > Then we probably could move clk_bulk_get into clk-devres.c as well which > is controlled by common CONFIG_HAVE_CLK to benifit all platforms.
clk-devres is for devm* things. I'd just make another file for now, clk-bulk.c or something like that. When everyone moves to common clk, we can fold it into clk.c, or not because clk.c is rather large right now.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |