lkml.org 
[lkml]   [2017]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] Staging: most: use __func__ instead of the function name

Third Reminder. Please review.

--
Chandra


On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote:

>
> Second reminder, please review.
>
> Thanks.
> Chandra
>
>
> On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@gmail.com>
> wrote:
>
> Change video.c to use %s, __func__ instead of function names.
> Warnings flagged by checkpatch.pl
>
> Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
>
> diff --git a/drivers/staging/most/aim-v4l2/video.c
> b/drivers/staging/most/aim-v4l2/video.c
> index e074841..59e861e 100644
> --- a/drivers/staging/most/aim-v4l2/video.c
> +++ b/drivers/staging/most/aim-v4l2/video.c
> @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
>         struct most_video_dev *mdev = video_drvdata(filp);
>         struct aim_fh *fh;
>
> -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
> +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
>         switch (vdev->vfl_type) {
>         case VFL_TYPE_GRABBER:
> @@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp)
>         struct most_video_dev *mdev = fh->mdev;
>         struct mbo *mbo, *tmp;
>
> -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n");
> +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
>         /*
>          * We need to put MBOs back before we call
> most_stop_channel()
> @@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file,
> void *priv, v4l2_std_id *norm)
>         struct aim_fh *fh = priv;
>         struct most_video_dev *mdev = fh->mdev;
>
> -       v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n");
> +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
>         *norm = V4L2_STD_UNKNOWN;
>         return 0;
> @@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file,
> void *priv, unsigned int index)
>         struct aim_fh *fh = priv;
>         struct most_video_dev *mdev = fh->mdev;
>
> -       v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n",
> index);
> +       v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index);
>
>         if (index >= V4L2_AIM_MAX_INPUT)
>                 return -EINVAL;
> @@ -441,7 +441,7 @@ static int aim_register_videodev(struct
> most_video_dev *mdev)
>  {
>         int ret;
>
> -       v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n");
> +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
>         init_waitqueue_head(&mdev->wait_data);
>
> @@ -471,7 +471,7 @@ static int aim_register_videodev(struct
> most_video_dev *mdev)
>
>  static void aim_unregister_videodev(struct most_video_dev
> *mdev)
>  {
> -       v4l2_info(&mdev->v4l2_dev,
> "aim_unregister_videodev()\n");
> +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
>         video_unregister_device(mdev->vdev);
>  }
>
>
>
>
\
 
 \ /
  Last update: 2017-04-21 09:40    [W:0.129 / U:5.136 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site