lkml.org 
[lkml]   [2017]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.
From
Date
  Hi,

> > My personal opinion is that formats in drm_fourcc.h should be
> > independent of the CPU byte order and the function
> > drm_mode_legacy_fb_format() and drivers depending on that incorrect
> > assumption be fixed instead.
>
> The problem is this isn't a kernel-internal thing any more. With the
> addition of the ADDFB2 ioctl the fourcc codes became part of the
> kernel/userspace abi ...

Ok, added some printk's to the ADDFB and ADDFB2 code paths and tested a
bit. Apparently pretty much all userspace still uses the ADDFB ioctl.
xorg (modesetting driver) does. gnome-shell in wayland mode does.
Seems the big transition to ADDFB2 didn't happen yet.

I guess that makes changing drm_mode_legacy_fb_format + drivers a
reasonable option ...

cheers,
Gerd

\
 
 \ /
  Last update: 2017-04-21 23:37    [W:0.159 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site