Messages in this thread | | | Subject | Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() | From | Joe Perches <> | Date | Fri, 21 Apr 2017 11:22:49 -0700 |
| |
On Fri, 2017-04-21 at 19:36 +0800, Herbert Xu wrote: > On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > > Date: Wed, 19 Apr 2017 10:50:04 +0200 > > > > The script "checkpatch.pl" pointed information out like the following. > > > > WARNING: quoted string split across lines > > > > Thus fix the affected source code places. > > > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > > This patch doesn't seem to add any value so I'm not taking it.
Your choice.
The general reason to merge strings is in CodingStyle
2) Breaking long lines and strings [] never break user-visible strings such as printk messages, because that breaks the ability to grep for them.
| |