Messages in this thread Patch in this message | | | From | Andrey Smirnov <> | Subject | [PATCH v5 4/6] mtd: dataflash: Get rid of loop counter in jedec_probe() | Date | Fri, 21 Apr 2017 09:30:24 -0700 |
| |
"For" loop in jedec_probe can be simplified to not need counter 'i'. Convert the code and get rid of the variable.
Cc: cphealy@gmail.com Cc: David Woodhouse <dwmw2@infradead.org> Cc: Brian Norris <computersforpeace@gmail.com> Cc: Boris Brezillon <boris.brezillon@free-electrons.com> Cc: Marek Vasut <marek.vasut@gmail.com> Cc: Richard Weinberger <richard@nod.at> Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com> Cc: linux-kernel@vger.kernel.org Reviewed-by: Marek Vasut <marek.vasut@gmail.com> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> ---
No changes since [v4]
Changes since [v3]
- Collected Reviewed-by from Marek
Not present in v2, v1
[v3] http://lkml.kernel.org/r/20170419152305.17226-4-andrew.smirnov@gmail.com [v4] http://lkml.kernel.org/r/20170420162952.5181-4-andrew.smirnov@gmail.com
drivers/mtd/devices/mtd_dataflash.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c index ccd1e02..2d3e403 100644 --- a/drivers/mtd/devices/mtd_dataflash.c +++ b/drivers/mtd/devices/mtd_dataflash.c @@ -736,7 +736,7 @@ static struct flash_info dataflash_data[] = { static struct flash_info *jedec_probe(struct spi_device *spi) { - int ret, i; + int ret; u8 code = OP_READ_ID; u8 id[3]; u32 jedec; @@ -767,9 +767,9 @@ static struct flash_info *jedec_probe(struct spi_device *spi) jedec = jedec << 8; jedec |= id[2]; - for (i = 0, info = dataflash_data; - i < ARRAY_SIZE(dataflash_data); - i++, info++) { + for (info = dataflash_data; + info < dataflash_data + ARRAY_SIZE(dataflash_data); + info++) { if (info->jedec_id == jedec) { dev_dbg(&spi->dev, "OTP, sector protect%s\n", (info->flags & SUP_POW2PS) ? -- 2.9.3
| |