lkml.org 
[lkml]   [2017]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] Added paranthesis around complex define statements
On Fri, Apr 21, 2017 at 05:15:46AM +0000, Andriy Gelman wrote:
> This is a patch to the ks_wlan_ioctl.h file that fixes paranthesis error
> found by the checkpatch.pl tool

No, it also does other things :(

Also, please fix up the subject to look like other patches done for this
file/driver.

And fix the spelling mistake :)

>
> Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
> ---
> drivers/staging/ks7010/ks_wlan_ioctl.h | 53 +++++++++++++++++-----------------
> 1 file changed, 26 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
> index 8e62b10..851f563 100644
> --- a/drivers/staging/ks7010/ks_wlan_ioctl.h
> +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
> @@ -1,6 +1,6 @@
> /*
> * Driver for KeyStream 11b/g wireless LAN
> - *
> + *

This is not a () change :(

Please only do one type of thing in each patch.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-04-21 07:24    [W:0.034 / U:10.368 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site