lkml.org 
[lkml]   [2017]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] PCI: disable SERR for kdump kernel
From
Date
On 4/20/2017 7:37 PM, Yinghai Lu wrote:
> On Thu, Apr 20, 2017 at 10:14 AM, Sinan Kaya <okaya@codeaurora.org> wrote:
>> On 4/18/2017 8:31 PM, Yinghai Lu wrote:
>>> * pci_setup_device - fill in class and map information of a device
>>> * @dev: the device structure to fill
>>> @@ -1572,6 +1592,9 @@ int pci_setup_device(struct pci_dev *dev
>>> /* device class may be changed after fixup */
>>> class = dev->class >> 8;
>>>
>>> + if (is_kdump_kernel())
>>> + pci_disable_serr(dev);
>>> +
>>
>> This sounds like something that needs to be done while shutting down
>> the first kernel as part of the kdump procedure rather than boot of
>> the kdump kernel in pci setup.
>
> For kdump path, first kernel shutdown path is not called.
>
> We have to do sth in second kernel instead.
>

I didn't know that. Bjorn's compatibility point is also a concern.
Ideally you want something in both places.

> Thanks
>
> Yinghai
>


--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2017-04-21 02:04    [W:0.062 / U:28.332 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site