lkml.org 
[lkml]   [2017]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] iio: inkern: fix a static checker error
From
Date
On 2017-04-20 23:12, Lars-Peter Clausen wrote:
> On 04/20/2017 11:01 PM, Peter Rosin wrote:
>> Avoid this smatch error:
>> drivers/iio/inkern.c:751 iio_read_avail_channel_raw() error: double unlock 'mutex:&chan->indio_dev->info_exist_lock'
>
> Looks good, but it's not just the smatch error, this is a real issue. This
> even seems to be a endless loop, always jumping back to err_unlock.

Yes, it should probably go to stable too...

>>
>> Fixes: 00c5f80c2fad ("iio: inkern: add helpers to query available values from channels")
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>
>> ---
>> drivers/iio/inkern.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
>> index 7a13535dc3e9..a3941bade6a7 100644
>> --- a/drivers/iio/inkern.c
>> +++ b/drivers/iio/inkern.c
>> @@ -750,11 +750,9 @@ int iio_read_avail_channel_raw(struct iio_channel *chan,
>> err_unlock:
>> mutex_unlock(&chan->indio_dev->info_exist_lock);
>>
>> - if (ret >= 0 && type != IIO_VAL_INT) {
>> + if (ret >= 0 && type != IIO_VAL_INT)
>> /* raw values are assumed to be IIO_VAL_INT */
>> ret = -EINVAL;
>> - goto err_unlock;
>> - }
>>
>> return ret;
>> }
>>
>

\
 
 \ /
  Last update: 2017-04-20 23:14    [W:0.049 / U:0.188 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site