lkml.org 
[lkml]   [2017]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 22/29] dt-bindings: Clarify compatible property for rockchip timers
On Sun, Apr 16, 2017 at 10:27:12PM +0200, Daniel Lezcano wrote:
> From: Alexander Kochetkov <al.kochet@gmail.com>
>
> Make all properties description in form '"rockchip,<chip>-timer",
> "rockchip,rk3288-timer"' for all chips found in linux kernel.
>
> Suggested-by: Heiko Stübner <heiko@sntech.de>
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> .../devicetree/bindings/timer/rockchip,rk-timer.txt | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/rockchip,rk-timer.txt b/Documentation/devicetree/bindings/timer/rockchip,rk-timer.txt
> index a41b184..16a5f45 100644
> --- a/Documentation/devicetree/bindings/timer/rockchip,rk-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/rockchip,rk-timer.txt
> @@ -1,9 +1,15 @@
> Rockchip rk timer
>
> Required properties:
> -- compatible: shall be one of:
> - "rockchip,rk3288-timer" - for rk3066, rk3036, rk3188, rk322x, rk3288, rk3368
> - "rockchip,rk3399-timer" - for rk3399
> +- compatible: should be:

should be one of:

> + "rockchip,rk3036-timer", "rockchip,rk3288-timer": for Rockchip RK3036
> + "rockchip,rk3066-timer", "rockchip,rk3288-timer": for Rockchip RK3066
> + "rockchip,rk3188-timer", "rockchip,rk3288-timer": for Rockchip RK3188
> + "rockchip,rk3228-timer", "rockchip,rk3288-timer": for Rockchip RK3228
> + "rockchip,rk3229-timer", "rockchip,rk3288-timer": for Rockchip RK3229
> + "rockchip,rk3288-timer": for Rockchip RK3288
> + "rockchip,rk3368-timer", "rockchip,rk3288-timer": for Rockchip RK3368
> + "rockchip,rk3399-timer": for Rockchip RK3399

I find the "for Rockchip RKxxxx" a bit redundant, but it's fine with or
without. Otherwise,

Acked-by: Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2017-04-20 16:14    [W:0.140 / U:0.412 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site