lkml.org 
[lkml]   [2017]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output
From
Date
On 18/04/17 09:46, Paul Kocialkowski wrote:
> Hi,
>
> Le lundi 17 avril 2017 à 21:36 +0200, Geert Uytterhoeven a écrit :
>> On Mon, Apr 17, 2017 at 5:38 PM, Paul Kocialkowski <contact@paulk.fr> wrote:
>>> Le dimanche 16 avril 2017 à 22:55 +0200, Geert Uytterhoeven a écrit :
>>>> On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski <contact@paulk.fr>
>>>> wrote:
>>>>> The move to a dedicated pwm_backlight_initial_power_state function in
>>>>> commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition
>>>>> to set the enable gpio as output. This breaks specific use cases using
>>>>> that GPIO, such as tegra124-based nyan Chromebooks where backlight
>>>>> stopped working.
>>>>>
>>>>> This puts the condition back to the way it was before the move.
>>>>>
>>>>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>>>>
>>>> Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented
>>>> .get_direction()"
>>>> (https://lkml.org/lkml/2017/4/4/225) fix your issue?
>>>
>>> This definitely solves the issue!
>>>
>>> Since this fixes broken backlight (that, in turn, makes systems unusable),
>>> perhaps this should be included in the next rc cycle?
>>
>> You mean v4.11 final, as there probably won't be another rc?
>> Yes!
>
> I'm all for it!

Thanks for keeping our attention on this. I sent a PR yesterday (and
hope my GPG key has attracted enough signatures).


Daniel.

\
 
 \ /
  Last update: 2017-04-20 11:55    [W:0.058 / U:3.052 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site