lkml.org 
[lkml]   [2017]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups
On Thu, Apr 20, 2017 at 5:25 AM, Darren Hart <dvhart@infradead.org> wrote:
> From: "Darren Hart (VMware)" <dvhart@infradead.org>
>
> This series factors out some redundant code, cleans up a number of style issues,
> modernizes the sysfs usage, and cleans up the return paths. All told, the driver
> is reduced in size by 37 lines (3.6%).
>
> I do not have an HP laptop, so I'm hoping Carlo can help out with some testing.
> In particular we need to verify that hotkeys and sysfs continue to work as
> before.
>

Series looks good to me except patch 2. So,

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

with above exception.

> This series is also available here for convenience:
> git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git hp-wmi
>
>
> Darren Hart (VMware) (9):
> platform/x86: hp-wmi: Cleanup local variable declarations
> platform/x86: hp-wmi: Add bios_args initializer
> platform/x86: hp-wmi: Standardize enum usage for constants
> platform/x86: hp-wmi: Refactor redundant HPWMI_READ functions
> platform/x86: hp-wmi: Cleanup wireless get_(hw|sw)state functions
> platform/x86: hp-wmi: Refactor dock and tablet state fetchers
> platform/x86: hp-wmi: Use DEVICE_ATTR_(RO|RW) helper macros
> platform/x86: hp-wmi: Do not shadow errors in sysfs show functions
> platform/x86: hp-wmi: Cleanup exit paths
>
> drivers/platform/x86/hp-wmi.c | 385 +++++++++++++++++++-----------------------
> 1 file changed, 174 insertions(+), 211 deletions(-)
>
> --
> 2.9.3
>



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-04-20 09:39    [W:0.103 / U:44.856 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site