lkml.org 
[lkml]   [2017]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] gpu: host1x: select IOMMU_IOVA
From
Date
Ah, had to forget something :)

Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>

On 19.04.2017 21:24, Arnd Bergmann wrote:
> When IOMMU_IOVA is not built-in but host1x is, we get a link error:
>
> drivers/gpu/host1x/dev.o: In function `host1x_remove':
> dev.c:(.text.host1x_remove+0x50): undefined reference to `put_iova_domain'
> drivers/gpu/host1x/dev.o: In function `host1x_probe':
> dev.c:(.text.host1x_probe+0x31c): undefined reference to `init_iova_domain'
> dev.c:(.text.host1x_probe+0x38c): undefined reference to `put_iova_domain'
> drivers/gpu/host1x/cdma.o: In function `host1x_cdma_init':
> cdma.c:(.text.host1x_cdma_init+0x238): undefined reference to `alloc_iova'
> cdma.c:(.text.host1x_cdma_init+0x2c0): undefined reference to `__free_iova'
> drivers/gpu/host1x/cdma.o: In function `host1x_cdma_deinit':
> cdma.c:(.text.host1x_cdma_deinit+0xb0): undefined reference to `free_iova'
>
> This adds the same select statement that we have for drm_tegra.
>
> Fixes: 404bfb78daf3 ("gpu: host1x: Add IOMMU support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/host1x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> index b2fd029d67b3..91916326957f 100644
> --- a/drivers/gpu/host1x/Kconfig
> +++ b/drivers/gpu/host1x/Kconfig
> @@ -1,6 +1,7 @@
> config TEGRA_HOST1X
> tristate "NVIDIA Tegra host1x driver"
> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> + select IOMMU_IOVA if IOMMU_SUPPORT
> help
> Driver for the NVIDIA Tegra host1x hardware.
>
>

\
 
 \ /
  Last update: 2017-04-20 08:52    [W:0.036 / U:3.596 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site