lkml.org 
[lkml]   [2017]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: iio: replace comma with a semicolon
From
Date
On 30/03/17 19:34, Arushi Singhal wrote:
>
>
> On Thu, Mar 30, 2017 at 11:46 PM, Jonathan Cameron <jic23@kernel.org <mailto:jic23@kernel.org>> wrote:
>
> On 30/03/17 13:41, Arushi Singhal wrote:
> > Replace a comma between expression statements by a semicolon. This
> > changes the semantics of the code, but given the current indentation
> > appears to be what is intended.
> > A simplified version of the Coccinelle semantic patch that performs this
> > transformation is as follows:
> >
> > // <smpl>
> > @r@
> > expression e1,e2;
> > @@
> >
> > e1
> > -,
> > +;
> > e2;
> > // </smpl>
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com <mailto:arushisinghal19971997@gmail.com>>
> As per the discussion about the other one. This is perfectly
> correct, but weird enough that I think we'll clear it out.
>
>
> Applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.
>
> I did add chemical to the title though to make it clearer what
> this was covering.
>
> Thanks Jonathan
> Do I need to resend it with revised patch subject.
> Arushi
Nope. I tend to just fix things like that when applying
(unless it's a repeat of something I have been moaning about in which
case I might bounce it back for another version!) Honestly it's
quicker to just fix it than to have to go through another round of
patches.

Just occasionally I mess it such fixes up though so always worth a
quick check when I have applied a patch.

Jonathan
>
>
> Thanks,
>
> Jonathan
> > ---
> > drivers/iio/chemical/ams-iaq-core.c | 2 +-
> > drivers/iio/chemical/vz89x.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/chemical/ams-iaq-core.c b/drivers/iio/chemical/ams-iaq-core.c
> > index 41a8e6f2e31d..c948ad2ee9ad 100644
> > --- a/drivers/iio/chemical/ams-iaq-core.c
> > +++ b/drivers/iio/chemical/ams-iaq-core.c
> > @@ -163,7 +163,7 @@ static int ams_iaqcore_probe(struct i2c_client *client,
> > mutex_init(&data->lock);
> >
> > indio_dev->dev.parent = &client->dev;
> > - indio_dev->info = &ams_iaqcore_info,
> > + indio_dev->info = &ams_iaqcore_info;
> > indio_dev->name = dev_name(&client->dev);
> > indio_dev->modes = INDIO_DIRECT_MODE;
> >
> > diff --git a/drivers/iio/chemical/vz89x.c b/drivers/iio/chemical/vz89x.c
> > index 8e0e4415c161..f75eea6822f2 100644
> > --- a/drivers/iio/chemical/vz89x.c
> > +++ b/drivers/iio/chemical/vz89x.c
> > @@ -393,7 +393,7 @@ static int vz89x_probe(struct i2c_client *client,
> > mutex_init(&data->lock);
> >
> > indio_dev->dev.parent = &client->dev;
> > - indio_dev->info = &vz89x_info,
> > + indio_dev->info = &vz89x_info;
> > indio_dev->name = dev_name(&client->dev);
> > indio_dev->modes = INDIO_DIRECT_MODE;
> >
> >
>
>

\
 
 \ /
  Last update: 2017-04-02 11:05    [W:0.045 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site