Messages in this thread | | | Subject | Re: [PATCH] phy/ethtool: Add missing SPEED_<foo> strings | From | Joe Perches <> | Date | Sun, 02 Apr 2017 14:49:18 -0700 |
| |
On Sun, 2017-04-02 at 23:40 +0200, Andrew Lunn wrote: > On Sun, Apr 02, 2017 at 02:30:06PM -0700, Joe Perches wrote: > > Add all the currently available SPEED_<foo> strings. [] > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h [] > > @@ -1487,6 +1487,7 @@ enum ethtool_link_mode_bit_indices { > > */ > > > > /* The forced speed, in units of 1Mb. All values 0 to INT_MAX are legal. */ > > Hi Joe > > Given that this list is getting longer and longer, and the comment > that 0..INT_MAX are legal, is it time to replace this with something > dynamic?
Hey Andrew.
Probably not.
INT_MAX in units of millions is likely large enough for quite awhile yet, maybe 2 decades or even more.
If you feel ambitious, and remember ethtool.h and SPEED_<foo> uses are a public API, write something up.
cheers, Joe
| |