Messages in this thread | | | Subject | Re: [PATCH] staging: rtl8723bs: remove redundant comparisons of unsigned ints with >= 0 | From | Hans de Goede <> | Date | Fri, 14 Apr 2017 14:15:22 +0200 |
| |
Hi,
On 13-04-17 16:13, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The comparison of mode >= 0 is redundant as mode is a u32 and this > is always true. Remove this redundant code. > > Detected with CoverityScan ("Unsigned compared against 0") > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > drivers/staging/rtl8723bs/core/rtw_debug.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c > index 51cef55d3f76..fc6b94d59c37 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_debug.c > +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c > @@ -1031,7 +1031,7 @@ ssize_t proc_set_ht_enable(struct file *file, const char __user *buffer, size_t > if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { > sscanf(tmp, "%d ", &mode); > > - if (pregpriv && mode >= 0 && mode < 2) { > + if (pregpriv && mode < 2) { > pregpriv->ht_enable = mode; > printk("ht_enable =%d\n", pregpriv->ht_enable); > } > @@ -1150,7 +1150,7 @@ ssize_t proc_set_rx_ampdu(struct file *file, const char __user *buffer, size_t c > > sscanf(tmp, "%d ", &mode); > > - if (pregpriv && mode >= 0 && mode < 2) { > + if (pregpriv && mode < 2) { > pmlmeinfo->bAcceptAddbaReq = mode; > DBG_871X("pmlmeinfo->bAcceptAddbaReq =%d\n", pmlmeinfo->bAcceptAddbaReq); > if (mode == 0) { > @@ -1191,7 +1191,7 @@ ssize_t proc_set_en_fwps(struct file *file, const char __user *buffer, size_t co > if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { > sscanf(tmp, "%d ", &mode); > > - if (pregpriv && mode >= 0 && mode < 2) { > + if (pregpriv && mode < 2) { > pregpriv->check_fw_ps = mode; > DBG_871X("pregpriv->check_fw_ps =%d\n", pregpriv->check_fw_ps); > } >
| |