Messages in this thread | | | Date | Thu, 13 Apr 2017 11:53:50 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 4/6] perf report: hint .perfconfig error when invalid sorting key |
| |
Em Wed, Apr 12, 2017 at 09:34:37AM -0700, David Carrillo-Cisneros escreveu: > > On Tue, Apr 11, 2017 at 11:49:17PM -0700, David Carrillo-Cisneros wrote: > >> My fat-fingering of sort keys in .perfconfig was a common cause of > >> perf report silently terminating without apparent error. > >> > >> This was because 1) error in setup_sorting in cmd_report was ignored > >> and 2) no message was log in UI browser that would prevent UI from > >> exit before user prompt. Fix both. > > > > there's UI init ahead of this code.. I had to move it > > below your code to spot any error message > > > > there's other errors further on.. perhaps we should move it even further ;-) > > or cancel the ui before the error is printed > > Probably canceling ui on error is the more robust way to go. I will > look into it.
So I'll wait for a v2 for this specific patch.
| |