Messages in this thread Patch in this message | | | From | Jan Glauber <> | Subject | [PATCH 1/2] mmc: cavium: Remove redundant pointer check | Date | Thu, 13 Apr 2017 14:10:50 +0200 |
| |
Remove redundant mmc->card check reported by smatch:
drivers/mmc/host/cavium.c:694 cvm_mmc_dma_request() warn: variable dereferenced before check 'mmc->card' (see line 675)
Signed-off-by: Jan Glauber <jglauber@cavium.com> --- drivers/mmc/host/cavium.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/cavium.c b/drivers/mmc/host/cavium.c index d842b69..ddf902c 100644 --- a/drivers/mmc/host/cavium.c +++ b/drivers/mmc/host/cavium.c @@ -691,7 +691,7 @@ static void cvm_mmc_dma_request(struct mmc_host *mmc, * bit mask to check for CRC errors and timeouts only. * Otherwise, use the default power reset value. */ - if (mmc->card && mmc_card_sd(mmc->card)) + if (mmc_card_sd(mmc->card)) writeq(0x00b00000ull, host->base + MIO_EMM_STS_MASK(host)); else writeq(0xe4390080ull, host->base + MIO_EMM_STS_MASK(host)); -- 2.9.0.rc0.21.g7777322
| |