lkml.org 
[lkml]   [2017]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH tip/core/rcu 07/13] rcu: Add smp_mb__after_atomic() to sync_exp_work_done()
    On Thu, Apr 13, 2017 at 11:18:32AM +0200, Peter Zijlstra wrote:
    > On Wed, Apr 12, 2017 at 09:55:43AM -0700, Paul E. McKenney wrote:
    > > However, a little future-proofing is a good thing,
    > > especially given that smp_mb__before_atomic() is only required to
    > > provide acquire semantics rather than full ordering. This commit
    > > therefore adds smp_mb__after_atomic() after the atomic_long_inc()
    > > in sync_exp_work_done().
    >
    > Oh!? As far as I'm away the smp_mb__{before,after}_atomic() really must

    s/away/aware/ typing hard

    > provide full MB, no confusion about that.
    >
    > We have other primitives for acquire/release.

    \
     
     \ /
      Last update: 2017-04-13 11:34    [W:2.574 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site