lkml.org 
[lkml]   [2017]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 03/17] buffer: use mapping_set_error instead of setting the flag
    On Wed 12-04-17 08:06:00, Jeff Layton wrote:
    > Signed-off-by: Jeff Layton <jlayton@redhat.com>

    Looks good. You can add:

    Reviewed-by: Jan Kara <jack@suse.cz>

    Honza

    > ---
    > fs/buffer.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/fs/buffer.c b/fs/buffer.c
    > index 9196f2a270da..70638941066d 100644
    > --- a/fs/buffer.c
    > +++ b/fs/buffer.c
    > @@ -483,7 +483,7 @@ static void __remove_assoc_queue(struct buffer_head *bh)
    > list_del_init(&bh->b_assoc_buffers);
    > WARN_ON(!bh->b_assoc_map);
    > if (buffer_write_io_error(bh))
    > - set_bit(AS_EIO, &bh->b_assoc_map->flags);
    > + mapping_set_error(bh->b_assoc_map, -EIO);
    > bh->b_assoc_map = NULL;
    > }
    >
    > --
    > 2.9.3
    >
    --
    Jan Kara <jack@suse.com>
    SUSE Labs, CR

    \
     
     \ /
      Last update: 2017-04-12 14:17    [W:4.246 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site