Messages in this thread | | | Date | Tue, 11 Apr 2017 14:44:02 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] mm, numa: Fix bad pmd by atomically check for pmd_trans_huge when marking page tables prot_numa |
| |
On Tue, 11 Apr 2017 08:35:02 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:
> >> I have Kirrill's > >> > >> thp-reduce-indentation-level-in-change_huge_pmd.patch > >> thp-fix-madv_dontneed-vs-numa-balancing-race.patch > >> mm-drop-unused-pmdp_huge_get_and_clear_notify.patch > >> thp-fix-madv_dontneed-vs-madv_free-race.patch > >> thp-fix-madv_dontneed-vs-madv_free-race-fix.patch > >> thp-fix-madv_dontneed-vs-clear-soft-dirty-race.patch > >> > >> scheduled for 4.12-rc1. It sounds like > >> thp-fix-madv_dontneed-vs-madv_free-race.patch and > >> thp-fix-madv_dontneed-vs-madv_free-race.patch need to be boosted to > >> 4.11 and stable? > > > > thp-fix-madv_dontneed-vs-numa-balancing-race.patch is the fix for > > numa balancing problem reported in this thread. > > > > mm-drop-unused-pmdp_huge_get_and_clear_notify.patch, > > thp-fix-madv_dontneed-vs-madv_free-race.patch, > > thp-fix-madv_dontneed-vs-madv_free-race-fix.patch, and > > thp-fix-madv_dontneed-vs-clear-soft-dirty-race.patch > > > > are the fixes for other potential race problems similar to this one. > > > > I think it is better to have all these patches applied. > > Yeah we should get all such fixes to stable IMHO (after review :). It's > not the first time that a fix for MADV_DONTNEED turned out to also fix a > race that involved "normal operation" with THP, without such syscalls.
The presence of thp-reduce-indentation-level-in-change_huge_pmd.patch is a pain in the ass but I've decided to keep it rather than churning all the patches at a late stage.
| |