lkml.org 
[lkml]   [2017]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] lightnvm: fix type checks on rrpc
From
Date
On 04/11/2017 04:18 PM, Javier González wrote:
> sector_t is always unsigned, therefore avoid < 0 checks on it.
>
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
> drivers/lightnvm/rrpc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
> index 5dba544..cf0e28a 100644
> --- a/drivers/lightnvm/rrpc.c
> +++ b/drivers/lightnvm/rrpc.c
> @@ -817,7 +817,7 @@ static int rrpc_read_ppalist_rq(struct rrpc *rrpc, struct bio *bio,
>
> for (i = 0; i < npages; i++) {
> /* We assume that mapping occurs at 4KB granularity */
> - BUG_ON(!(laddr + i >= 0 && laddr + i < rrpc->nr_sects));
> + BUG_ON(!(laddr + i < rrpc->nr_sects));
> gp = &rrpc->trans_map[laddr + i];
>
> if (gp->rblk) {
> @@ -846,7 +846,7 @@ static int rrpc_read_rq(struct rrpc *rrpc, struct bio *bio, struct nvm_rq *rqd,
> if (!is_gc && rrpc_lock_rq(rrpc, bio, rqd))
> return NVM_IO_REQUEUE;
>
> - BUG_ON(!(laddr >= 0 && laddr < rrpc->nr_sects));
> + BUG_ON(!(laddr < rrpc->nr_sects));
> gp = &rrpc->trans_map[laddr];
>
> if (gp->rblk) {
>
Thanks. Applied for 4.12.

\
 
 \ /
  Last update: 2017-04-11 16:36    [W:0.063 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site