Messages in this thread | | | From | "Ghannam, Yazen" <> | Subject | RE: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers | Date | Tue, 11 Apr 2017 13:50:02 +0000 |
| |
> -----Original Message----- > From: Borislav Petkov [mailto:bp@alien8.de] > Sent: Tuesday, April 11, 2017 9:36 AM > To: Ghannam, Yazen <Yazen.Ghannam@amd.com> > Cc: linux-edac@vger.kernel.org; Tony Luck <tony.luck@intel.com>; > x86@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA > MCA_DE{STAT,ADDR} registers > > On Tue, Apr 11, 2017 at 01:32:03PM +0000, Ghannam, Yazen wrote: > > Yes, exactly. Deferred errors are *always* logged in the DE* registers and > > Then the solution is simple: > > for_each_bank() > if (log_error()) { > clear_msrs();
We need to make sure log_error() logged the deferred error before clearing MCA_DESTAT. We shouldn't assume that it did because we're in the #DF handler. There's still a possibility that it was overwritten even if very rare.
> continue; > } > > if (mca_cfg.smca) { > log_error_from_de_regs() > clear_msrs(); > } > } > > and clear_msrs() clears them all. >
Thanks, Yazen
| |