Messages in this thread | | | Subject | Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() | From | Richard Weinberger <> | Date | Tue, 11 Apr 2017 12:50:04 +0200 |
| |
Hi!
Am 11.04.2017 um 12:20 schrieb Amir Goldstein: > On Thu, Apr 6, 2017 at 3:26 PM, Richard Weinberger <richard@nod.at> wrote: >> Am 06.04.2017 um 14:09 schrieb Richard Weinberger: >>>> Were you able to make any progress? still working on this? >>>> If this is too complicated to get in for this cycle, better send a patch >>>> to disable O_TMPFILE support for ubifs and fix the problem properly on >>>> followup merge cycle. >>>> Because right now ubifs O_TMPFILE support is broken and breaks overlayfs mount. >>> >>> I have a test and currently testing it. As it looks the situation is less worse >>> than I thought first. :-) >> >> s/test/patch :) >> > > Richard, > > Maybe it's not my business to interfere with ubifs development and I > haven't seen your patch. > > But on the face of it, it doesn't sound like fixing O_TMPFILE is a > trivial fix, so not sure > it is wise to send a patch for -rc7?... > > How about sending the patch to disable O_TMPFILE for -rc7 and queuing > your fix for v4.12? > Without any patch, v4.11 is going to have a regression with overlayfs+ubifs.
No need to panic. I verified some stuff and my first patch does the right thing but not in a nice way, except in oneerror patch. In will land in -rc7.
For the next merge window I prepare patches that introduce a new journal function for handling tmpfiles.
Thanks, //richard
| |