Messages in this thread | | | Date | Mon, 10 Apr 2017 18:38:49 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH] mm, numa: Fix bad pmd by atomically check for pmd_trans_huge when marking page tables prot_numa |
| |
On Mon, Apr 10, 2017 at 03:53:42PM +0200, Michal Hocko wrote: > > While this could be fixed with heavy locking, it's only necessary to > > make a copy of the PMD on the stack during change_pmd_range and avoid > > races. A new helper is created for this as the check if quite subtle and the > > existing similar helpful is not suitable. This passed 154 hours of testing > > s@helpful@helper@ I suspect >
Yes. I'll wait to see if there is more feedback and if not, resend unless Andrew decides to pick it up and correct the mistake directly.
> > (usually triggers between 20 minutes and 24 hours) without detecting bad > > PMDs or corruption. A basic test of an autonuma-intensive workload showed > > no significant change in behaviour. > > > > Signed-off-by: Mel Gorman <mgorman@techsingularity.net> > > Cc: stable@vger.kernel.org > > Acked-by: Michal Hocko <mhocko@suse.com> >
Thanks.
> you will probably win the_longest_function_name_contest but I do not > have much better suggestion. >
I know, it's not a type of function that yields a snappy name.
-- Mel Gorman SUSE Labs
| |