lkml.org 
[lkml]   [2017]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303
On Mon, Apr 10, 2017 at 09:44:12AM +0200, Juergen Borleis wrote:
> Hi Andrew,
>
> On Friday 07 April 2017 16:29:43 Andrew Lunn wrote:
> > > +static int lan9303_virt_phy_reg_read(struct lan9303 *chip, int regnum)
> > > +{
> > > + int ret;
> > > + u32 val;
> > > +
> > > + if (regnum > MII_EXPANSION) {
> > > + if (regnum == MII_LAN911X_SPECIAL_CONTROL_STATUS)
> > > + regnum = 7; /* map to LAN9303_VIRT_SPECIAL_CTRL */
> > > + else
> > > + return -EINVAL;
> > > + }
> >
> > What PHY ID does the virtual PHY use? The same as the LAN911X? Or
> > something different.
>
> Something different: 0x00000000 (instead of 0x0007c0d1 the real PHYs are
> using).

Hi Juergen

0x0 does not help us. We cannot bind a specific PHY driver to that.

> For the virtual PHY the driver states (MDIO emulation case):
>
> Generic PHY 63fec000.etherne:00: attached PHY driver [Generic PHY] (mii_bus:phy_addr=63fec000.etherne:00, irq=-1)

This is what i would expect. But i think that means the redirect of
MII_LAN911X_SPECIAL_CONTROL_STATUS to 7 is pointless. The generic PHY
only uses registers below MII_EXPANSION. So unless there is a use of
MII_LAN911X_SPECIAL_CONTROL_STATUS i don't see, you might as well
remove this.

Andrew

\
 
 \ /
  Last update: 2017-04-10 15:26    [W:0.066 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site