Messages in this thread | | | Date | Tue, 11 Apr 2017 09:42:23 +0800 | From | Wei Yang <> | Subject | Re: [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed |
| |
On Mon, Apr 10, 2017 at 05:26:03PM -0700, David Rientjes wrote: >On Tue, 11 Apr 2017, Wei Yang wrote: > >> According to current code path, numa_nodes_parsed is already setup when >> numa_emucation() is called. >> >> x86_numa_init() >> numa_init() >> init_func() >> >> numa_emulation() >> >> numa_register_memblks() >> > >s/numa_emucation/numa_emulation/, but I think everything above should just >be reworded to say the following since it establishes the dependency: > >numa_init() has already called init_func(), which is responsible for >setting numa_nodes_parsed, so use this nodemask instead of re-finding it >when calling numa_emulation(). >
Yep, thanks.
Looks your change log is better :-)
>> This means we can get the physnode_mask directly from numa_nodes_parsed. At >> the same time, this patch correct the comment of these two functions. >> >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > >Acked-by: David Rientjes <rientjes@google.com>
-- Wei Yang Help you, Help me [unhandled content-type:application/pgp-signature] | |