Messages in this thread | | | Subject | Re: [PATCH] iio: adc: hx711: constify attribute_group structures | From | Jonathan Cameron <> | Date | Sat, 1 Apr 2017 11:39:20 +0100 |
| |
On 01/04/17 09:17, simran singhal wrote: > Check for attribute_group structures that are only stored in the > attrs filed of iio_info structure. As the attrs field of iio_info > structures is constant, so these attribute_group structures can also be > declared constant. > Done using coccinelle: > > @r1 disable optional_qualifier @ > identifier i; > position p; > @@ > static struct attribute_group i@p = {...}; > > @ok1@ > identifier r1.i; > position p; > struct iio_info x; > @@ > x.attrs=&i@p; > > @bad@ > position p!={r1.p,ok1.p}; > identifier r1.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > static > +const > struct attribute_group i={...}; > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > +const > struct attribute_group i; > > File size before: > text data bss dec hex filename > 3042 480 0 3522 dc2 drivers/iio/adc/hx711.o > > File size after: > text data bss dec hex filename > 3098 416 0 3514 dba drivers/iio/adc/hx711.o > > Signed-off-by: simran singhal <singhalsimran0@gmail.com> Applied. > --- > drivers/iio/adc/hx711.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c > index 139639f..27005d8 100644 > --- a/drivers/iio/adc/hx711.c > +++ b/drivers/iio/adc/hx711.c > @@ -369,7 +369,7 @@ static struct attribute *hx711_attributes[] = { > NULL, > }; > > -static struct attribute_group hx711_attribute_group = { > +static const struct attribute_group hx711_attribute_group = { > .attrs = hx711_attributes, > }; > >
| |