Messages in this thread | | | Subject | Re: [v2, 4/4] dt-bindings: mtd: Add Octal SPI support to Cadence QSPI. | From | Marek Vasut <> | Date | Fri, 10 Mar 2017 04:39:27 +0100 |
| |
On 03/08/2017 09:05 AM, Artur Jedrysek wrote: > This patch updates Cadence QSPI Device Tree documentation to include > information about new compatible used to indicate, whether or not > Octal SPI transfers are supported by the device. > > Signed-off-by: Artur Jedrysek <jartur@cadence.com> > --- > Changelog: > v2: Use new compatible, instead of boolean property, to indicate > Octal SPI support. > --- > Documentation/devicetree/bindings/mtd/cadence-quadspi.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt b/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt > index f248056..41d1e98 100644 > --- a/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt > +++ b/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt > @@ -1,7 +1,9 @@ > * Cadence Quad SPI controller > > Required properties: > -- compatible : Should be "cdns,qspi-nor". > +- compatible : Should be "cdns,{qspi|ospi}-nor".
Please explicitly list all compatibles , ie. Should be "cdns,qspi-nor" or "cdns,ospi-nor".
But I think the ospi is backward compatible with qspi, right ? So the binding for ospi should list both, ie. compatible = "cdns,ospi-nor", "cdns,qspi-nor";
> + Use "cdns,qspi-nor" for Quad SPI controller. > + Use "cdns,ospi-nor" for Octal SPI controller. > - reg : Contains two entries, each of which is a tuple consisting of a > physical address and length. The first entry is the address and > length of the controller register set. The second entry is the >
-- Best regards, Marek Vasut
| |