Messages in this thread | | | Subject | Re: [PATCH 1/3] futex: remove duplicated code | From | Vineet Gupta <> | Date | Thu, 9 Mar 2017 14:43:40 -0800 |
| |
On 03/03/2017 04:27 AM, Jiri Slaby wrote: > There is code duplicated over all architecture's headers for > futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr, > and comparison of the result. > > Remove this duplication and leave up to the arches only the needed > assembly which is now in arch_futex_atomic_op_inuser. > > Note that s390 removed access_ok check in d12a29703 ("s390/uaccess: > remove pointless access_ok() checks") as access_ok there returns true. > We introduce it back to the helper for the sake of simplicity (it gets > optimized away anyway).
Acked-by: Vineet Gupta <vgupta@synopsys.com> # Boot tested on ARC
Thx, -Vineet
| |