Messages in this thread | | | Subject | Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq() | From | Vignesh R <> | Date | Thu, 9 Mar 2017 20:07:24 +0530 |
| |
Hi,
On Wednesday 08 March 2017 06:04 PM, Greg Kroah-Hartman wrote: > On Wed, Mar 08, 2017 at 05:49:43PM +0530, Vignesh R wrote: >> Passing "serial" as name during request_irq() results in all serial port >> irqs have same name. This does not help much to easily identify which >> irq belongs to which serial port instance. Therefore pass dev_name() >> during request_irq() so that better identifiable name is listed for >> serial ports in cat /proc/interrupts output. >> >> Output of cat /proc/interrupts >> Before this patch: >> 26: 689 0 GICv2 309 Edge serial >> After this patch: >> 26: 696 0 GICv2 309 Edge 2530c00.serial >> >> Signed-off-by: Vignesh R <vigneshr@ti.com> > > I need a "full" name here, unless you really do sign legal documents > with just one letter as a last/sur-name? >
Its perfectly alright not to expand surname here in India. FWIW, my ID cards also have the same name. I have been contributing to the kernel with above Signed-off-by line in the past and would want to continue to use the same.
-- Regards Vignesh
| |