lkml.org 
[lkml]   [2017]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem
    From
    Date
    Hello!

    On 3/9/2017 11:39 AM, Sekhar Nori wrote:

    >>> It took a while to get to it but here is the draft driver patch
    >>> against v4.11-rc1. Please test.
    >>
    >> I tested this on DM6446 EVM. I was able to mount existing partitions on
    >> the hard disk and see that the directory listing looks good[1]. I will do
    >> more tests (including comparing performance with old driver) tomorrow. I
    >
    > I completed the tests I wanted to, including some read/write/data
    > integrity tests. Performance is same as before too.
    >
    > Tested-by: Sekhar Nori <nsekhar@ti.com>
    >
    > Here are the additional changes I did. These changes do not clash with
    > what I have already queued for v4.12. That said, its probably better if
    > I carry the platform pieces through my tree. Let me know how you want
    > to proceed.
    >
    > Thanks,
    > Sekhar
    >
    > ---8<---
    > diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig
    > index b9a7cb98ffda..67db82999c06 100644
    > --- a/arch/arm/configs/davinci_all_defconfig
    > +++ b/arch/arm/configs/davinci_all_defconfig
    [...]
    > diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
    > index 023480b75244..60a1f23890cd 100644
    > --- a/arch/arm/mach-davinci/board-dm644x-evm.c
    > +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
    > @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device *phydev)
    > return 0;
    > }
    >
    > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710)
    > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710)

    I think it would be more correct to check for both libata and IDE drivers
    here...

    > #define HAS_NOR IS_ENABLED(CONFIG_MTD_PHYSMAP)
    >
    > diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
    > index f702d4fc8eb8..589f3c33c4a0 100644
    > --- a/arch/arm/mach-davinci/board-dm646x-evm.c
    > +++ b/arch/arm/mach-davinci/board-dm646x-evm.c
    > @@ -119,7 +119,7 @@ static struct platform_device davinci_nand_device = {
    > },
    > };
    >
    > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710)
    > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710)

    And here...

    >
    > #ifdef CONFIG_I2C
    > /* CPLD Register 0 bits to control ATA */
    > diff --git a/arch/arm/mach-davinci/board-neuros-osd2.c b/arch/arm/mach-davinci/board-neuros-osd2.c
    > index 0a7838852649..075e304ce7be 100644
    > --- a/arch/arm/mach-davinci/board-neuros-osd2.c
    > +++ b/arch/arm/mach-davinci/board-neuros-osd2.c
    > @@ -163,7 +163,7 @@ static struct davinci_mmc_config davinci_ntosd2_mmc_config = {
    > .wires = 4,
    > };
    >
    > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710)
    > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710)

    And here...

    [...]

    MBR, Sergei

    \
     
     \ /
      Last update: 2017-03-09 10:30    [W:4.730 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site