lkml.org 
[lkml]   [2017]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm,hugetlb: compute page_size_log properly
> One example of the problems with extra layers what this patch fixes:
> mmap_pgoff() should never be using SHM_HUGE_* logic. This was
> introduced by:
>
> 091d0d55b28 (shm: fix null pointer deref when userspace specifies invalid hugepage size)
>
> It is obviously harmless but lets just rip out the whole thing --
> the shmget.2 manpage will need updating, as it should not be
> describing kernel internals.

The SHM_* defines were supposed to be exported to user space,
but somehow they didn't make it into uapi.

But something like this is useful, it's a much nicer
interface for users than to hard code the bit position

So I would rather if you move it to uapi instead of
removing. What the kernel uses internally doesn't
really matter.

-Andi

\
 
 \ /
  Last update: 2017-03-08 20:39    [W:0.177 / U:3.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site