Messages in this thread | | | Date | Wed, 8 Mar 2017 16:27:55 +0200 | From | Yuval Shaia <> | Subject | Re: [PATCH 14/26] IB/ocrdma: Improve another size determination in ocrdma_add() |
| |
On Wed, Mar 08, 2017 at 02:10:33PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 7 Mar 2017 22:12:36 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c > index 9caa4c564e34..c49b4491d4e7 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c > @@ -303,7 +303,7 @@ static struct ocrdma_dev *ocrdma_add(struct be_dev_info *dev_info) > u8 lstate = 0; > struct ocrdma_dev *dev; > > - dev = (struct ocrdma_dev *)ib_alloc_device(sizeof(struct ocrdma_dev)); > + dev = (struct ocrdma_dev *)ib_alloc_device(sizeof(*dev)); > if (!dev) { > pr_err("Unable to allocate ib device\n"); > return NULL;
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |