lkml.org 
[lkml]   [2017]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ?
    From
    Date
    Hi David, Inki,

    Thanks for reporting.

    On 06.03.2017 11:05, David Binderman wrote:
    > Hello there,
    >
    > linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) Result of operator '|' is always true if one operand is non-zero. Did you intend to use '&'?
    >
    > Source code is
    >
    > if (ctx->out_type | I80_HW_TRG) {
    >
    > Also in the same file:
    >
    > [drivers/gpu/drm/exynos/exynos5433_drm_decon.c:131]: (style) Same expression on both sides of '|'.
    >
    > Source code is
    >
    > writel(TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN
    > | TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN,

    This typo was already reported by:
    - Ilia Mirkin, I have uploaded 2nd fixed version of the patch,
    apparently the 1st version has been merged [1],
    - Dan Carpenter, he posted also the fix[2],
    - and now David.

    I guess at the moment the best solution is to get Dan's patch.

    [1]: https://patchwork.kernel.org/patch/9493177/
    [2]: https://patchwork.kernel.org/patch/9571375/

    Regards
    Andrzej

    >
    > Regards
    >
    > David Binderman
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel


    \
     
     \ /
      Last update: 2017-03-08 10:02    [W:2.933 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site