Messages in this thread | | | From | Gary Bisson <> | Date | Tue, 7 Mar 2017 18:26:12 +0100 | Subject | Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups |
| |
Hi Fabio,
On Tue, Mar 7, 2017 at 6:19 PM, Fabio Estevam <festevam@gmail.com> wrote: > Hi Gary, > > On Mon, Jan 2, 2017 at 4:20 PM, Gary Bisson > <gary.bisson@boundarydevices.com> wrote: >> Now using group_desc structure instead of imx_pin_group. >> >> Also leveraging generic functions to retrieve groups count/name/pins. >> >> The imx_free_pingroups function can be removed since it is now handled by >> the core driver during unregister. >> >> Finally the device tree parsing is moved after the pinctrl driver registration >> since this latter initializes the radix trees. >> >> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > > This patch is in 4.11-rc1 now and it causes a regression on the hog group: > > [ 0.061005] imx6q-pinctrl 20e0000.iomuxc: unable to find group for > node hoggrp > > The hog pins can no longer be initialized. > > Could you take a look, please?
No it isn't because of the use of radix but instead of: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=950b0d91dc10
It has been discussed here: https://lkml.org/lkml/2017/2/28/140
Tony offered a patch in that thread which works. Tony, have you submitted it yet?
Regards, Gary
| |