lkml.org 
[lkml]   [2017]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly
    On Tue, Mar 07, 2017 at 03:10:20PM +0100, Michal Hocko wrote:
    > From: Michal Hocko <mhocko@suse.com>
    >
    > __vmalloc* allows users to provide gfp flags for the underlying
    > allocation. This API is quite popular
    > $ git grep "=[[:space:]]__vmalloc\|return[[:space:]]*__vmalloc" | wc -l
    > 77
    >
    > the only problem is that many people are not aware that they really want
    > to give __GFP_HIGHMEM along with other flags because there is really no
    > reason to consume precious lowmemory on CONFIG_HIGHMEM systems for pages
    > which are mapped to the kernel vmalloc space. About half of users don't
    > use this flag, though. This signals that we make the API unnecessarily
    > too complex.
    >
    > This patch simply uses __GFP_HIGHMEM implicitly when allocating pages to
    > be mapped to the vmalloc space. Current users which add __GFP_HIGHMEM
    > are simplified and drop the flag.
    >
    > Signed-off-by: Michal Hocko <mhocko@suse.com>

    Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>

    \
     
     \ /
      Last update: 2017-03-07 19:47    [W:3.805 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site