lkml.org 
[lkml]   [2017]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] genirq: Add support for nested shared IRQs
    Date
    I am working on a system which has an audio CODEC and two speaker amps,
    each of the speaker amps have an open-drain IRQ line which are connected
    together and attached to a pin on the audio CODEC, which is capable of
    functioning as an IRQ chip. The audio CODEC then in turn has its own IRQ
    line which heads back to the host processor.

    This setup necessitates having a shared nested IRQ on the audio CODEC.
    Currently however the kernel does not appear to support shared nested
    IRQs.

    Fortunately support is fairly easy to add, only required the
    modification of handle_nested_irq to call all the IRQ handlers, rather
    than just the first one associated with the IRQ.

    Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
    ---

    Changes since v1:
    - Improve commit messages
    - Use for_each_action_of_desc
    - Correct handling of note_interrupt

    Thanks,
    Charles

    kernel/irq/chip.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
    index be3c34e..686be4b 100644
    --- a/kernel/irq/chip.c
    +++ b/kernel/irq/chip.c
    @@ -348,7 +348,10 @@ void handle_nested_irq(unsigned int irq)
    irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS);
    raw_spin_unlock_irq(&desc->lock);

    - action_ret = action->thread_fn(action->irq, action->dev_id);
    + action_ret = IRQ_NONE;
    + for_each_action_of_desc(desc, action)
    + action_ret |= action->thread_fn(action->irq, action->dev_id);
    +
    if (!noirqdebug)
    note_interrupt(desc, action_ret);

    --
    2.1.4
    \
     
     \ /
      Last update: 2017-03-07 17:56    [W:2.973 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site