Messages in this thread | | | From | "Naveen N. Rao" <> | Subject | Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel | Date | Tue, 7 Mar 2017 16:17:35 +0530 |
| |
On 2017/03/06 10:06PM, Masami Hiramatsu wrote: > On Mon, 6 Mar 2017 23:19:09 +0530 > "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote: > > > Masami, > > Your patch works, thanks! However, I felt we could refactor and reuse > > some of the code across kprobes.c for this purpose. Can you please see > > if the below patch is fine? > > OK, looks good to me:) > > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks for the review, Masami! I ended up adding one more patch to this series (patch 5/6) to move the ftrace README scanning out of probe-file.c, as it doesn't need libelf. Patch 6 fails to build without libelf otherwise. Please take a look.
Arnaldo, I am re-sending the remaining patches in this series which apply on top of the 4 patches you sent to Ingo, so as to keep this simple. All the patches have been acked, except the new patch 5/6. Kindly take a look.
Thanks, Naveen
-- Naveen N. Rao (6): trace/kprobes: fix check for kretprobe offset within function entry powerpc: kretprobes: override default function entry offset perf: probe: factor out the ftrace README scanning perf: kretprobes: offset from reloc_sym if kernel supports it perf: probes: move ftrace README parsing logic into trace-event-parse.c perf: powerpc: choose local entry point with kretprobes
arch/powerpc/kernel/kprobes.c | 9 +++ include/linux/kprobes.h | 1 + kernel/kprobes.c | 40 ++++++++----- kernel/trace/trace_kprobe.c | 2 +- tools/perf/arch/powerpc/util/sym-handling.c | 10 ++-- tools/perf/util/probe-event.c | 12 ++-- tools/perf/util/probe-file.c | 80 +++----------------------- tools/perf/util/probe-file.h | 1 - tools/perf/util/trace-event-parse.c | 89 +++++++++++++++++++++++++++++ tools/perf/util/trace-event.h | 4 ++ 10 files changed, 149 insertions(+), 99 deletions(-)
-- 2.11.1
| |