Messages in this thread | | | Date | Tue, 7 Mar 2017 10:30:30 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] tpm/tpm_crb: enter the low power state upon device suspend |
| |
On Mon, Mar 06, 2017 at 06:19:59PM +0000, Winkler, Tomas wrote: > > > > > On Mon, Mar 06, 2017 at 01:53:35AM +0200, Tomas Winkler wrote: > > > This fix enables a platform to enter the idle state (suspend-to-idle) > > > > > > The driver needs to request explicitly go_idle upon completion from > > > the pm suspend handler. > > > The runtime pm is disabled on suspend during prepare state by calling > > > pm_runtime_get_noresume, hence we cannot relay on runtime pm to leave > > > the device in low power state. Symmetrically cmdReady is called upon > > > resume. > > > > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > > > > LGTM > > > > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > > > PS. What about Fixes? Does this need it? > > No, I don't think this is a regression caused by any patch, rather the pm solution was not complete. > Thanks > Tomas
It's in my tree now (and should be in linux-next too soon).
/Jarkko
| |