Messages in this thread Patch in this message | | | Date | Mon, 6 Mar 2017 14:34:03 -0500 (EST) | From | Chad Dupuis <> | Subject | Re: [PATCH] scsi: qedf: Use vsprintf extension %pad |
| |
On Mon, 6 Mar 2017, 6:32pm -0000, Joe Perches wrote:
> Using %llx for a dma_addr_t can lead to format/argument mismatches. > Use %pad and the address of the dma_addr_t instead. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/scsi/qedf/qedf_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c > index d9d7a86b5f8b..8e2a160490e6 100644 > --- a/drivers/scsi/qedf/qedf_main.c > +++ b/drivers/scsi/qedf/qedf_main.c > @@ -2456,8 +2456,8 @@ static int qedf_alloc_bdq(struct qedf_ctx *qedf) > } > > QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_DISC, > - "BDQ PBL addr=0x%p dma=0x%llx.\n", qedf->bdq_pbl, > - qedf->bdq_pbl_dma); > + "BDQ PBL addr=0x%p dma=%pad\n", > + qedf->bdq_pbl, &qedf->bdq_pbl_dma); > > /* > * Populate BDQ PBL with physical and virtual address of individual >
Looks good.
Acked-by: Chad Dupuis <chad.dupuis@cavium.com>
| |