Messages in this thread | | | Date | Mon, 6 Mar 2017 16:49:09 +0000 | From | Charles Keepax <> | Subject | Re: [PATCH v2] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range |
| |
On Sat, Mar 04, 2017 at 08:20:11PM +0900, Tomasz Figa wrote: > Hi Charles, > > 2017-03-01 2:04 GMT+09:00 Charles Keepax <ckeepax@opensource.wolfsonmicro.com>: > > As the pinctrl is now added before the GPIOs are registered we need to > > manually calculate what the GPIO base will be, otherwise the base for > > each gpio_range will be set to zero. Fortunately the driver > > already assigns a GPIO base, in samsung_gpiolib_register, and uses the > > same calculation it does for the pin_base. Meaning the two will always > > be the same and allowing us to reuse the pinbase and avoid the issue. > > Sorry, I didn't notice before and I don't see the offending patch in , > but you should add > > Fixes: XXXXXXXXXXXX ("pinctrl: Patch subject") > > if you intend to submit this patch separately. Otherwise, maybe this > can be just squashed? >
Yeah apologies for that as the original patch hasn't showed up in the tree yet I couldn't pull a commit ID to add the fixes tag. Squashing it in is probably the best way to go.
Thanks, Charles
| |