lkml.org 
[lkml]   [2017]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 07/26] brcmsmac: reduce stack size with KASAN
    On Mon, Mar 6, 2017 at 12:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:
    > On Mon, Mar 6, 2017 at 12:02 PM, Arend Van Spriel
    > <arend.vanspriel@broadcom.com> wrote:
    >> On 6-3-2017 11:38, Arnd Bergmann wrote:
    >>> On Mon, Mar 6, 2017 at 10:16 AM, Arend Van Spriel
    >>> <arend.vanspriel@broadcom.com> wrote:

    >> Given the amount of local variables maybe just tag the functions with
    >> noinline instead.
    >
    > But that would result in less efficient object code without KASAN,
    > as inlining these by default is a good idea when the stack variables
    > all get folded.

    Note that David Laight alread suggested renaming noinline_for_kasan
    to noinline_if_stackbloat, which makes it a little more obvious what
    is going on. Would that address your concern as well?

    Arnd

    \
     
     \ /
      Last update: 2017-03-06 12:32    [W:3.459 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site