lkml.org 
[lkml]   [2017]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] nilfs2: set the mapping error when calling SetPageError on writeback
    Date
    In a later patch, we're going to want to make the fsync codepath not do
    a TestClearPageError call as that can override the error set in the
    address space. To do that though, we need to ensure that filesystems
    that are relying on the PG_error bit for reporting writeback errors
    also set an error in the address space.

    The only place I've found that looks potentially problematic is this
    spot in nilfs2. Ensure that it sets an error in the mapping in addition
    to setting PageError.

    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    ---
    fs/nilfs2/segment.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
    index bedcae2c28e6..c1041b07060e 100644
    --- a/fs/nilfs2/segment.c
    +++ b/fs/nilfs2/segment.c
    @@ -1743,6 +1743,7 @@ static void nilfs_end_page_io(struct page *page, int err)
    } else {
    __set_page_dirty_nobuffers(page);
    SetPageError(page);
    + mapping_set_error(page_mapping(page), err);
    }

    end_page_writeback(page);
    --
    2.9.3
    \
     
     \ /
      Last update: 2017-03-05 14:53    [W:4.189 / U:0.788 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site