Messages in this thread | | | Date | Sat, 4 Mar 2017 17:42:17 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2] staging: ks7010: fix sparse warnings |
| |
On Sat, Mar 04, 2017 at 10:56:23AM +0200, Ernestas Kulik wrote: > Currently, sparse generates many warnings for the driver. This commit > changes the types of struct fields/function variables to match the > endianness at their assignment. > > Signed-off-by: Ernestas Kulik <ernestas.kulik@gmail.com> > --- > Changes from v1: > * Change the type of the variable being passed to ntohs() instead of casting it > * Don’t remove any struct fields
[ snip ]
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c > index 6f9f746a3a61..8e644ff8eca8 100644 > --- a/drivers/staging/ks7010/ks7010_sdio.c > +++ b/drivers/staging/ks7010/ks7010_sdio.c > @@ -297,7 +297,8 @@ static int write_to_device(struct ks_wlan_private *priv, unsigned char *buffer, > hdr = (struct hostif_hdr *)buffer; > > DPRINTK(4, "size=%d\n", hdr->size); > - if (hdr->event < HIF_DATA_REQ || HIF_REQ_MAX < hdr->event) { > + if (le16_to_cpu(hdr->event) < HIF_DATA_REQ || > + HIF_REQ_MAX < le16_to_cpu(hdr->event)) {
Don't mix cleanups and bugfixes. They have to be done in separate patches. Also this change wasn't described in the changelog like Joe explained.
regards, dan carpenter
| |