lkml.org 
[lkml]   [2017]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/6] mm: remove return value from init_currently_empty_zone
Date
On March 31, 2017 2:49 PM Michal Hocko wrote: 
> On Fri 31-03-17 11:49:49, Hillf Danton wrote:
> [...]
> > > -/* Can fail with -ENOMEM from allocating a wait table with vmalloc() or
> > > - * alloc_bootmem_node_nopanic()/memblock_virt_alloc_node_nopanic() */
> > > -static int __ref ensure_zone_is_initialized(struct zone *zone,
> > > +static void __ref ensure_zone_is_initialized(struct zone *zone,
> > > unsigned long start_pfn, unsigned long num_pages)
> > > {
> > > - if (zone_is_empty(zone))
> > > - return init_currently_empty_zone(zone, start_pfn, num_pages);
> > > -
> > > - return 0;
> > > + if (!zone_is_empty(zone))
> > > + init_currently_empty_zone(zone, start_pfn, num_pages);
> > > }
> > Semantic change added?
>
> could you be more specific?

Well, I'm wondering why you are trying to initiate a nonempty zone.

Hillf

\
 
 \ /
  Last update: 2017-03-31 09:08    [W:0.899 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site