lkml.org 
[lkml]   [2017]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] xen: make functions in xen-acpi-processor return void
From
Date
On 31/03/17 17:15, Konrad Rzeszutek Wilk wrote:
> On Fri, Mar 31, 2017 at 04:40:56PM +0200, Juergen Gross wrote:
>> There are several functions in xen-acpi-processor which either always
>> return the same value or where the returned value is never checked.
>>
>> Make the functions return void.
>
> Well, we could actually check it and do some extra error reporting?
> (Does it even make sense?)
>
> Granted the code was done this way so that if we did fail - we would
> try to continue on instead of giving up.
>
> Perhaps you can include that in the commit description? Thanks

Okay. I'll change the commit description.


Juergen

\
 
 \ /
  Last update: 2017-03-31 17:31    [W:0.041 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site