Messages in this thread | | | Subject | Re: [PATCH v2] xen,kdump: handle pv domain in paddr_vmcoreinfo_note() | From | Boris Ostrovsky <> | Date | Fri, 31 Mar 2017 10:02:23 -0400 |
| |
On 03/31/2017 06:14 AM, Juergen Gross wrote: > For kdump to work correctly it needs the physical address of > vmcoreinfo_note. When running as dom0 this means the virtual address > has to be translated to the related machine address. > > paddr_vmcoreinfo_note() is meant to do the translation via > __pa_symbol() only, but being attributed "weak" it can be replaced > easily in Xen case. > > Signed-off-by: Juergen Gross <jgross@suse.com>
Similar to Jan's concern, if bare-metal x86 people decide to have their own paddr_vmcoreinfo_note() (and they usually build with !CONFIG_XEN) we will have to update this again. I suppose we can deal with that if/when it happens since we will discover this immediately.
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
| |