lkml.org 
[lkml]   [2017]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] x86/numachip timer: set ->min_delta_ticks and ->max_delta_ticks
    Date
    In preparation for making the clockevents core NTP correction aware,
    all clockevent device drivers must set ->min_delta_ticks and
    ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
    clockevent device's rate is going to change dynamically and thus, the
    ratio of ns to ticks ceases to stay invariant.

    Make the numachip clockevent driver initialize these fields properly.

    This patch alone doesn't introduce any change in functionality as the
    clockevents core still looks exclusively at the (untouched) ->min_delta_ns
    and ->max_delta_ns. As soon as this has changed, a followup patch will
    purge the initialization of ->min_delta_ns and ->max_delta_ns from this
    driver.

    Signed-off-by: Nicolai Stange <nicstange@gmail.com>
    ---

    Notes:
    This prerequisite patch is part of a larger effort to feed NTP
    corrections into the clockevent devices' frequencies and thus
    avoiding their notion of time to diverge from the system's
    one. If you're interested, the current state of the whole series
    can be found at [1].

    If you haven't got any objections and these prerequisites get
    merged by 4.12 everywhere, I'll proceed with the remainder of
    this series in 4.13.

    Applicable to next-20170324 as well as to John' Stultz tree [2].

    [1]
    git://nicst.de/linux.git cev-freq-adj.v10.fortglx-4.12-time
    https://nicst.de/git/?p=linux.git;a=shortlog;h=refs/heads/cev-freq-adj.v10.fortglx-4.12-time

    [2]
    https://git.linaro.org/people/john.stultz/linux.git fortglx/4.12/time

    drivers/clocksource/numachip.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/clocksource/numachip.c b/drivers/clocksource/numachip.c
    index 4e0f11fd2617..6a20dc8b253f 100644
    --- a/drivers/clocksource/numachip.c
    +++ b/drivers/clocksource/numachip.c
    @@ -51,7 +51,9 @@ static struct clock_event_device numachip2_clockevent = {
    .mult = 1,
    .shift = 0,
    .min_delta_ns = 1250,
    + .min_delta_ticks = 1250,
    .max_delta_ns = LONG_MAX,
    + .max_delta_ticks = LONG_MAX,
    };

    static void numachip_timer_interrupt(void)
    --
    2.12.0
    \
     
     \ /
      Last update: 2017-03-30 22:09    [W:4.399 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site