Messages in this thread | | | Date | Thu, 30 Mar 2017 08:49:58 +0200 | From | Peter Zijlstra <> | Subject | Re: in_irq_or_nmi() and RFC patch |
| |
On Wed, Mar 29, 2017 at 09:44:41PM +0200, Jesper Dangaard Brouer wrote: > @@ -2481,7 +2481,11 @@ void free_hot_cold_page(struct page *page, bool cold) > unsigned long pfn = page_to_pfn(page); > int migratetype; > > - if (in_interrupt()) { > + /* > + * Exclude (hard) IRQ and NMI context from using the pcplists. > + * But allow softirq context, via disabling BH. > + */ > + if (in_irq() || irqs_disabled()) {
Why do you need irqs_disabled() ? Also, your comment is stale, it still refers to NMI context.
> __free_pages_ok(page, 0); > return; > }
| |