lkml.org 
[lkml]   [2017]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: adc: replace comma with a semicolon

> On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote:
> > Replace a comma between expression statements by a semicolon. This
> > changes the semantics of the code, but given the current indentation
> > appears to be what is intended.

> You can simply say that this fixes what appears to be a bug to me.
> I wonder how this does even compile..

it's valid C and I think it does the correct thing (i.e. assign those
variables); the style is weird obviously

> [1] https://marc.info/?l=linux-iio&m=148475728729617&w=2
>
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> > ---
> > drivers/iio/adc/max11100.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/adc/max11100.c b/drivers/iio/adc/max11100.c
> > index 23c060e1b663..1180bcc22ff1 100644
> > --- a/drivers/iio/adc/max11100.c
> > +++ b/drivers/iio/adc/max11100.c
> > @@ -124,8 +124,8 @@ static int max11100_probe(struct spi_device *spi)
> > indio_dev->name = "max11100";
> > indio_dev->info = &max11100_info;
> > indio_dev->modes = INDIO_DIRECT_MODE;
> > - indio_dev->channels = max11100_channels,
> > - indio_dev->num_channels = ARRAY_SIZE(max11100_channels),
> > + indio_dev->channels = max11100_channels;
> > + indio_dev->num_channels = ARRAY_SIZE(max11100_channels);
> >
> > state->vref_reg = devm_regulator_get(&spi->dev, "vref");
> > if (IS_ERR(state->vref_reg))
> > --
> > 2.11.0
> >
>

--

Peter Meerwald-Stadler
Mobile: +43 664 24 44 418

\
 
 \ /
  Last update: 2017-03-30 15:39    [W:1.365 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site